Conversation
p-sawicki
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store built
librtunderbuild/librt-cache, so that it can be reused to speed up mypyc tests when there are no changes undermypyc/lib-rt. Also invalidate the cache if the build environment changes.This also ensures that each test run only compiles
librtat most twice (with and without experimental features), instead of once per test case that requireslibrt.Use
filelockto support parallel tests.Building
librtcan take 6+ seconds, so the savings can be quite significant. We are also planning to add several additionallibrtsubmodules, which will further slow down the build, and this will result in a larger number of tests that requirelibrt. The main benefit is that adding more tests or submodules doesn't significantly slow down tests.